From b84b576a221684a39ef12891bafd233ba6289b09 Mon Sep 17 00:00:00 2001 From: "Claudius \"keldu\" Holeksa" Date: Sun, 11 Jun 2023 19:24:59 +0200 Subject: c++, codec-json: Added testing for tuples and fixed minor buffer changes --- src/codec-json/json.h | 27 ++++++++++----- src/codec-json/json.tmpl.h | 86 ++++++++++++++++++++++++++++++++++++++++++++-- src/codec/data.h | 13 +++++-- src/core/buffer.cpp | 18 +++++----- src/core/buffer.h | 14 +++++--- 5 files changed, 131 insertions(+), 27 deletions(-) (limited to 'src') diff --git a/src/codec-json/json.h b/src/codec-json/json.h index c8456b5..f547e54 100644 --- a/src/codec-json/json.h +++ b/src/codec-json/json.h @@ -10,11 +10,6 @@ namespace saw { namespace encode { struct Json {}; } -} - -#include "json.tmpl.h" - -namespace saw { template class data { @@ -23,12 +18,14 @@ private: public: data():buffer_{}{} + data(std::size_t ring_size_):buffer_{ring_size_}{} + buffer& get_buffer(){ return buffer_; } - void push(uint8_t val){ - buffer_.push(val); + error push(uint8_t val){ + return buffer_.push(val); } std::size_t get_size() const { @@ -43,6 +40,11 @@ public: return buffer_.read(i); } }; +} + +#include "json.tmpl.h" + +namespace saw { /** * Codec class for json @@ -71,9 +73,16 @@ public: SAW_DEFAULT_MOVE(codec); template - error_or encode(const data& from_encode, data& to_encode){ + error_or encode(const data& from_encode, data& to_encode){ // To Be encoded - return impl::json_encode::encode(from_encode, to_encode); + buffer_view buff_v{to_encode.get_buffer()}; + auto eov = impl::json_encode::encode(from_encode, buff_v); + if(eov.is_error()){ + return std::move(eov.get_error()); + } + to_encode.get_buffer().write_advance(buff_v.write_offset()); + + return void_t{}; } template diff --git a/src/codec-json/json.tmpl.h b/src/codec-json/json.tmpl.h index a19e3dc..0738277 100644 --- a/src/codec-json/json.tmpl.h +++ b/src/codec-json/json.tmpl.h @@ -10,8 +10,8 @@ class json_encode { }; template -struct json_encode, RootSchema, FromEncode> { - static error_or encode(const data, FromEncode>& from, data, encode::Json>& to) { +struct json_encode, RootSchema, FromEncode> { + static error_or encode(const data, FromEncode>& from, buffer& to) { auto val = from.get(); std::array data; auto tc_result = std::to_chars(reinterpret_cast(data.data()), reinterpret_cast(data.data())+data.size(), val); @@ -25,7 +25,7 @@ struct json_encode, RootSchema, FromEncode> { ++bytes_written; } - auto& buff = to.get_buffer(); + auto& buff = to; error err = buff.write_require_length(bytes_written); if(!err.template is_type()){ return std::move(err); @@ -39,5 +39,85 @@ struct json_encode, RootSchema, FromEncode> { return void_t{}; } }; + +template +struct json_encode { + static error_or encode(const data& from, buffer& to) { + { + auto err = to.push('"'); + if(!err.template is_type()){ + return err; + } + } + for(std::size_t i = 0; i < from.size(); ++i){ + auto err = to.push(from.get_at(i)); + if(!err.template is_type()){ + return err; + } + } + { + auto err = to.push('"'); + if(!err.template is_type()){ + return err; + } + } + + return void_t{}; + } +}; + +template +struct json_encode, RootSchema, FromEncode> { + + template + static error_or encode_element(const data, FromEncode>& from, buffer& to){ + auto eov = json_encode::type, RootSchema, FromEncode>::encode(from.template get(), to); + + if(eov.is_error()){ + return eov; + } + + if constexpr ( (i+1) < sizeof...(T)){ + { + auto eov_ele = to.push(','); + if(!eov_ele.template is_type()){ + return eov_ele; + } + } + { + auto eov_ele = encode_element(from, to); + if(eov_ele.is_error()){ + return eov_ele; + } + } + + + } + return void_t{}; + } + + static error_or encode(const data, FromEncode>& from, buffer& to) { + { + auto err = to.push('['); + if(!err.template is_type()){ + return err; + } + } + if constexpr ( sizeof...(T) > 0 ){ + auto eov = encode_element<0>(from, to); + if(eov.is_error()){ + return eov; + } + } + { + auto err = to.push(']'); + if(!err.template is_type()){ + return err; + } + } + + return void_t{}; + } +}; } } diff --git a/src/codec/data.h b/src/codec/data.h index 895a2fb..63bc752 100644 --- a/src/codec/data.h +++ b/src/codec/data.h @@ -110,8 +110,13 @@ public: SAW_DEFAULT_MOVE(data); template - data::type, encode::Native>& get(){ - return std::get(); + data::type, encode::Native>& get(){ + return std::get(value_); + } + + template + const data::type, encode::Native>& get() const{ + return std::get(value_); } constexpr size_t size() const { @@ -154,6 +159,10 @@ public: return value_.size(); } + void set(std::string str){ + value_ = std::move(str); + } + char get_at(size_t i) const{ return value_.at(i); } diff --git a/src/core/buffer.cpp b/src/core/buffer.cpp index 81fc0df..15f4cae 100644 --- a/src/core/buffer.cpp +++ b/src/core/buffer.cpp @@ -60,14 +60,7 @@ error buffer::pop(uint8_t &buffer, size_t size) { return no_error(); } -std::string buffer::to_string() const { - std::ostringstream oss; - for (size_t i = 0; i < read_composite_length(); ++i) { - oss << read(i); - } - return oss.str(); -} - +/* std::string buffer::to_hex() const { std::ostringstream oss; oss << std::hex << std::setfill('0'); @@ -79,6 +72,15 @@ std::string buffer::to_hex() const { } return oss.str(); } +*/ + +std::string convert_to_string(const buffer& buff){ + std::ostringstream oss; + for (size_t i = 0; i < buff.read_composite_length(); ++i) { + oss << buff.read(i); + } + return oss.str(); +} buffer_view::buffer_view(buffer &buffer) : buffer_{&buffer}, read_offset_{0}, write_offset_{0} {} diff --git a/src/core/buffer.h b/src/core/buffer.h index ff39aff..f0cf76e 100644 --- a/src/core/buffer.h +++ b/src/core/buffer.h @@ -47,13 +47,17 @@ public: error pop(uint8_t &value); error pop(uint8_t &buffer, size_t size); - /* - * Subject to change - */ - std::string to_string() const; - std::string to_hex() const; }; +/** + * Converts a buffer to a string for convenience cases + */ +std::string convert_to_string(const buffer& buf); + +/** + * + */ + /* * A viewer class for buffers. * Working on the reference buffer invalidates the buffer view -- cgit v1.2.3